search

heinrich5991 / libtw2

Some Teeworlds stuff in Rust.™
Apache License 2.0
49 stars 17 forks source link

doc-map: fix tile bitflag interpretation #98

Closed 66-m closed 3 months ago

66-m commented 4 months ago

The interpretation for the horizontal and vertical flips from the bitflag is the other way around.

The order of flips doesn't matter since it gives the same result, but to avoid confusion i swapped it too

heinrich5991 commented 4 months ago

The problem is that it's not clear what a horizontal flip is. Does the x-axis remain in place or the y-axis? Both could reasonably be described as a horizontal flip. We need more precise language here.

Patiga commented 4 months ago

Relevant context: https://github.com/ddnet/ddnet/pull/6132

The interpretation for the horizontal and vertical flips from the bitflag is the other way around.

The codebase had a different interpretation than the editor. I made the change to X/Y, which sadly didn't get any discussion, but should hopefully be more intuitive. x-flip switches left <-> right, y-flip up <-> down

This should ofc be updated in the map docs :+1:

heinrich5991 commented 3 months ago

Thanks for your pull request! I somehow forgot about it…