search

heinrich5991 / libtw2

Some Teeworlds stuff in Rust.™
Apache License 2.0
50 stars 16 forks source link

CI: Pip install huffman #99

Closed ChillerDragon closed 4 months ago

ChillerDragon commented 5 months ago

Should probably test installing it from the local source not from pypi. But I could not find the readme with the build instructions for the python package.

ChillerDragon commented 5 months ago

This pipeline used to pass for me 3 months ago https://github.com/ChillerDragon/teeworlds-web-traffic-decoder/commits/master/

heinrich5991 commented 4 months ago

Should probably test installing it from the local source not from pypi. But I could not find the readme with the build instructions for the python package.

Yes. I believe it was "do what you do to get any Python project built". I had to look it up again, found it at https://packaging.python.org/en/latest/tutorials/packaging-projects/: python -m build.

ChillerDragon commented 4 months ago

I didn't even see the pyproject.toml because i was looking in the huffman directory not in uniffi.

ChillerDragon commented 4 months ago

It is now building, installing and running the python package.

heinrich5991 commented 4 months ago

I added it to the existing CI. Thanks for your PR which prompted me to do this. I wanted to improve upon this PR in two ways: 1) It tested in three different Python versions which I didn't find necessary. 2) The unit test was quite ad-hoc. I added structured Python unit tests instead.

Superseded by 83f22dbfe713682f7c528473c2f727049928a9dd.