heinrisch / Contact-Picture-Sync

Sync Facebook profile pictures with android contacts
25 stars 14 forks source link

Friend detection of sync picture problem #6

Open eliseealex opened 10 years ago

eliseealex commented 10 years ago

I think there is an error with detection of synchronization of contact and profile picture in Friend.java:

public void savePictureHash(){ profilePictureSyncHash = profilePicture != null ? profilePicture.hashCode() : 0; } public boolean hasSyncedPicture(){ if(profilePicture == null) return false; return profilePictureSyncHash == profilePicture.hashCode(); }

As i can see we compare the same picture, instead of comparing profile and contact picture. Also the problem is that we do not create a hash before the first comparison pictures.