search

heisch / gloomhaven-item-db

https://heisch.github.io/gloomhaven-item-db/
16 stars 13 forks source link

Make the 'use' column sortable #3

Closed mikemorton closed 4 years ago

mikemorton commented 4 years ago

I'm interested in being able to sort the items based on whether they are consumed or spent when they are used. I made this small change to make that column sortable in the Table.

I spent 15 minutes on this change and almost 2 hours battling with react-scripts on my local system, unable to get it going. So I've been unable to test this! You may want to give it a whirl before you merge it in.

heisch commented 4 years ago

I'll have a look within the next days

heisch commented 4 years ago

Merged and deployed, you should be able to see the new feature now

mikemorton commented 4 years ago

Thanks Nicola, looks great!

(Avoiding spoilers, I recently started playing a class that can refresh items somewhat frequently so I'm looking forward to exploring the items in the DB in that way!)