search

heiseonline / perl-sentry-sdk

Other
8 stars 6 forks source link

Minimum Mojolicious version #13

Closed eserte closed 2 years ago

eserte commented 2 years ago

The test suite fails on some of my smokers:

# Premature connection close

#   Failed test 'GET /adds-breadcrumb'
#   at t/mojolicious-plugin-sentry-sdk.t line 92.

#   Failed test '200 OK'
#   at t/mojolicious-plugin-sentry-sdk.t line 92.
#          got: undef
#     expected: '200'

#   Failed test 'exact match for selector "Hello!"'
#   at t/mojolicious-plugin-sentry-sdk.t line 92.
#          got: ''
#     expected: undef

#   Failed test 'Mojolicious::Plugin::SentrySDK registers breadcrumbs'
#   at t/mojolicious-plugin-sentry-sdk.t line 95.
#          got: '0'
#     expected: '1'

#   Failed test 'Mojolicious::Plugin::SentrySDK registers breadcrumbs' by dying:
#     Modification of non-creatable array value attempted, subscript -1
#     at t/mojolicious-plugin-sentry-sdk.t line 97.
# Looks like you failed 5 tests of 5.
t/mojolicious-plugin-sentry-sdk.t .. 
Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/5 subtests

And sometimes

#   Failed test 'exact match for selector "Hello!"'
#   at t/mojolicious-plugin-sentry-sdk.t line 92.
#          got: ''
#     expected: undef
# Looks like you failed 1 test of 9.
t/mojolicious-plugin-sentry-sdk.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/9 subtests

It seems that this happens if Mojolicious is too old. 9.21 and greater seems to be OK, 9.19 and less is not (don't know about 9.20):

****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           0.0000          0.0000       3.56
[1='eq_8.12']         0.0000          0.0000       1.46
[2='eq_9.19']         0.0000          0.0000       0.00
[3='eq_9.21']         1.0000          0.0000    11352376583171680.00
[4='eq_9.22']         1.0000          0.0000    15784839073191284.00
[5='eq_9.23']         1.0000          0.0000    15626482830019862.00

R^2= 1.000, N= 59, K= 6
****************************************************************
pmb0 commented 2 years ago

Thanks! Should be fixed in the next version.