search

heiseonline / shariff-backend-php

👮 PHP backend for Shariff. Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
134 stars 44 forks source link

[TASK] Remove zend-json dependency #104

Closed liayn closed 8 years ago

liayn commented 8 years ago

Fixes: #56

liayn commented 8 years ago

I have not clue why codeclimate doesn't like my safe access to the GET variable. And the complaint about the else parts is also very funny.

liayn commented 8 years ago

The CS fixer results are wrong too. The functions require a null return value, hence a simple return; is semantically wrong. PHPStorm's inspections color that yellow immediately.

liayn commented 8 years ago

How can we get codeclimate and cs-fixer correct?

compeak commented 8 years ago

I "fixed" it by disabling the empty_return fixer and ignoring the codeclimate issues.

liayn commented 8 years ago

Thanks