search

heiseonline / shariff-backend-php

👮 PHP backend for Shariff. Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
134 stars 44 forks source link

Update Facebook service to latest Facebook Graph API version v3.2 #150

Closed richard67 closed 6 years ago

richard67 commented 6 years ago

Current Facebook Graph API version is v3.2, see https://developers.facebook.com/docs/graph-api/changelog.

There have not been any breaking changes regarding sharing counts, see https://developers.facebook.com/docs/graph-api/changelog/version3.2, so only the version number has to be increased with this PR here.

How to test: Code review should be sufficient, but if necessary, check if Facebook counts still work with this PR applied. Of course I've tested this on my website, as usual.

Reason for this PR:

As already elaborated in PR #128, Shariff backend will not get any result for an app_id if the app has been created with a newer Graph API version than the one which Shariff backend uses in the URL for getting the counts, because a Facebook app is limited to the minimum Graph API version which was current when the app has been created.

richard67 commented 6 years ago

@compeak Travis lint errors are as usual not related to this PR but to cloning the repo.

richard67 commented 6 years ago

@compeak I've forgotten to make an own branch for this PR, but for now it should be ok because this PR is the only difference between my master branch and heiseonline:master.

richard67 commented 6 years ago

@compeak Any plan to merge this PR?

compeak commented 6 years ago

Thanks. Sorry for the delay.