search

heiseonline / shariff-backend-php

👮 PHP backend for Shariff. Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
133 stars 44 forks source link

Use PSR HttpClient #151

Closed core23 closed 5 years ago

core23 commented 5 years ago

This feature is not BC. It will drop Guzzle and replaces it with the generic PSR Http Client. This is a framework agnostic standard for all http clients, so you can use this library with any other http client (e.g. buzz, curl guzzle5, guzzle, etc.)

Because the PSR Http Client requires PHP 7 (and PHP 5 will end in a few days), this PR also drops support for PHP5 and PHPUnit 5.

liayn commented 5 years ago

Can you maybe elaborate what the benefit is of moving to the PSR stub stuff and using an adapter instead of going guzzle directly?

core23 commented 5 years ago

Can you maybe elaborate what the benefit is of moving to the PSR stub stuff and using an adapter instead of going guzzle directly?

The reason for the guzzle adapter: https://github.com/heiseonline/shariff-backend-php/pull/151/files#r235761970

richard67 commented 5 years ago

Can you maybe elaborate what the benefit is of moving to the PSR stub stuff and using an adapter instead of going guzzle directly?

The reason for the guzzle adapter: https://github.com/heiseonline/shariff-backend-php/pull/151/files#r235761970

Just looking at the code changes does not enlight me about what the benefits are. Could you maybe explain them a bit more specific?