search

heiseonline / shariff-backend-php

👮 PHP backend for Shariff. Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
133 stars 44 forks source link

Remove LinkedIn share count API #159

Closed richard67 closed 5 years ago

richard67 commented 5 years ago

Pull request for issue #158 .

In February 2018, LinkedIn announced that their Share button will not show any counts anymore, and the API to fetch counts from also has been closed.

See announcement here: https://developer.linkedin.com/blog/posts/2018/deprecating-the-inshare-counter .

This pull request (PR) here removes the LinkedIn service from Shariff Backend PHP for the reasons stated above, like it had to be done in past with GooglePlus and Twitter for the same reasons (abandoned counting by the provider).

How to test: By code review, or set up a backend and check that the LinkedIn service is not available anymore.

richard67 commented 5 years ago

@compeak or other maintainers: This is not a BC break so I don't think it needs a new major version for a release, new minor version should be sufficient.

I will soon make a PR to remove the share counts for LinkedIn from the dummy backend (json file) used in the Shariff demo.

vkhramtsov commented 5 years ago

@richard67 @compeak Any news here?

richard67 commented 5 years ago

@vkhramtsov I am not a maintainer of this repository, I am only contributor, so I can’t decide when this pull request will be merged. But you can simply remove the LibkedIn service from index.php of your Shariff PHP backend, then the 404 error should disappear.

compeak commented 5 years ago

Thanks.

vkhramtsov commented 5 years ago

@richard67 @compeak Thank you