search

heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 177 forks source link

dynamic added data-url without effect #199

Open kkretsch opened 7 years ago

kkretsch commented 7 years ago

I'm adding the data-url parameter to the shariff div tag via onReady before loading the sharif.min.js and cann see the added url in the dom tree via page debugger in my browser. But the generated anchor tags submit the previous page url to the social media websites.

My hope was that the transmitted link would be the data-url address.

Or is that address only used for getting the pagecount from the optional shariff backend? in that case I pledge for the addition of using the data-url parameter as the submitted target url for the social sharing function.

axeff commented 7 years ago

Maybe this could help: https://github.com/heiseonline/shariff/pull/186 In this case, the url from location.href at the moment of clicking share button would be used