shariff.complete.js does not render buttons on Safari 10.1/Mac sporadically

heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.

http://ct.de/-2467514

MIT License

1.4k stars 177 forks source link

shariff.complete.js does not render buttons on Safari 10.1/Mac sporadically #245

Closed thasmo closed 7 years ago

thasmo commented 7 years ago

After resolving #243 I encountered shariff not rendering buttons sporadically after page load/refresh. This only seems to happen with shariff.complete.js. Using shariff.min.js it works in Safari 10.1/Mac, although it obviously breaks on IE.

thasmo commented 7 years ago

Nevermind, I didn't realize shariff.complete.js includes jQuery, which was the actual problem.

pmb0 commented 7 years ago

shariff.complete.js includes a custom polyfill of jQuery. Its document.ready code was buggy and was improved in https://github.com/heiseonline/shariff/commit/1cf07921d54682f6de8a1d08aaeea67ba4ac2f57. This improvement will be part of our next release.