search

heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 177 forks source link

1.26.0 release does not follow semver #246

Closed liayn closed 7 years ago

liayn commented 7 years ago

The build folder has been moved to dist, which is a major breaking change. This breaks automated scripts! Thus the version must be 2.0.0.

@pmb0 I suggest to:

liayn commented 7 years ago

Note: This is the second time such a mistake happens with Shariff. Please make sure Heise gets this straight for the future.

pmb0 commented 7 years ago

Renaming ./dist to ./build and releasing 1.26.1 should fix this -- right?

pmb0 commented 7 years ago

No, they are git-ignored now. I will publish a new release that contains ./build soon. After that i will release 2.0.0.

pmb0 commented 7 years ago

Is v1.26.1 fine for you?

liayn commented 7 years ago

Sure. As you like. Just make sure that people don't die if they update within v1. ;-)

liayn commented 7 years ago

Thanks for taking care quickly.