search

heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 177 forks source link

Incompatible with bootstrap v. 4 #300

Closed DeutscheBundesstiftungUmwelt closed 6 years ago

DeutscheBundesstiftungUmwelt commented 6 years ago

Hi folks, the col-statements in the .css and .js files do not work properly, if someone - like me - is using bootstrap 4. Therefore you can easily change the col-syntax (bootstrap 4 uses the same) to for example colSha- to work with bootstrap v 4 too. Thanks

flof commented 6 years ago

Same problem here. I have defined 3 services, so shariff adds the class "col-3" to the container element, which results (bacause of bootstrap) in a column, that is so small, that the share buttons don't fit into.

As workaround, I added a couple of null's to the services-array:

<div class="shariff" data-services="[&quot;twitter&quot;,&quot;facebook&quot;,&quot;googleplus&quot;,null,null,null]"></div>

This makes shariff add the class "col-6" to the container, which makes the container wide enough to fit the share buttons.

richard67 commented 6 years ago

@karacho @flof Pull request (PR) to correct your issue is PR #304 .

Can you test it as described in that PR and report back your test result there in a comment?

You can find packages for testing there, if necessary.

richard67 commented 6 years ago

Since PR #304 is merged, this issue can be closed.

compeak commented 6 years ago

This should be fixed in v3.0.0.