search

heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 177 forks source link

Shariff online demo on github.io is outdated and does not show share counts #312

Closed richard67 closed 6 years ago

richard67 commented 6 years ago

The Shariff online demo on github.io obviously is outdated, i.e. it does not reflect recent changes of shariff and demo code, e.g. new services, and it does not show any share counters.

The reason why the counters are missing is because value the data-backend-url attribute of the Shariff elements is /shariff/ and not the backend stub /backend.json, but there is no real backend installed, so calling the backend with correct parameters results in the nidex.html being shown.

This then results in following javascript error for file:line:row app.min.js:29:3501:

SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

I think frontend and demo just need to be updated, and possibly a real backend has to be installed, then it should work.

richard67 commented 6 years ago

@compeak Any idea about that?

compeak commented 6 years ago

@richard67 I updated the demo and fixed the backend URLs. Please check.

richard67 commented 6 years ago

@compeak Online demo works now. Shall I close this issue?

richard67 commented 6 years ago

Issue can be closed. Demo works now as expected.