search

heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 177 forks source link

XING share button not working #353

Closed neffets closed 5 years ago

neffets commented 5 years ago

The share button for XING is not working anymore.

The old url: https://www.xing.com/social_plugins/share?url= gives "not found" New url for static share link is: https://www.xing.com/spi/shares/new?url=

richard67 commented 5 years ago

@neffets I can't confirm that the link in Shariff is not working.

However, I can confirm that the new URL which you provide is equal to what https://github.com/vinkla/shareable-links/blob/master/README.md#xing, my favourite source for sharing links, sais.

There is also a link to the Xing documentation, which sais the same in section "Share on XING with custom design": https://dev.xing.com/plugins/share_button/docs.

Maybe the Shariff link still works for me because Xing has some kind of redirect?

Anyway, it seems you are right, and I will make a pull request (PR) to correct the link.

richard67 commented 5 years ago

@neffets Pull request (PR) is #354 . Could you test as described there, and if test is successful close this issue? If not, wait until the maintainers have made a new release of Shariff which includes the change from my PR, then update your Shariff to the new release, and then if all is ok close this issue if it is still open.

neffets commented 5 years ago

patch-1 from #354 is working

richard67 commented 5 years ago

You can close this issue now. The correction is included in the new release 3.2.0 from yesterday, April 1, 2019.

richard67 commented 5 years ago

@compeak This issue can be closed since it was corrected with #354 and released with 3.2.0.

neffets commented 5 years ago

In 3.2.0 working - Thanx