search

heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 176 forks source link

JavaScript Fehler in shariff.min.js:7 #364

Open Franzhitze opened 5 years ago

Franzhitze commented 5 years ago

There is a JavaScript Fehler in shariff.min.js with Joomla! Version 3.9.6. at shariff.min.js:7. You can see this in the web browser at developer tools.

This fault makes problems with other components, modules and plug-ins which do not work or do not work as intended.

Please eliminate this fault. Thanks

liayn commented 5 years ago

Feedback to your report: 1) Not everyone is using Joomla - don't expect others to install it just for debugging 2) What is the error message? 3) How do you integrate shariff in your site, what other Javascript is loaded?

Franzhitze commented 5 years ago

Answer: See the enclosed JPG file.

The component VisForms does not work anymore because of this fault:

Die Ursache des Problems ist, ein JavaScript Fehler. (Siehe beiliegender Screenshot). Dieser wird durch die Datei shariff.min.js hervorgehoben, die nicht von Visforms kommt. Aufgrund des Fehlers in dieser Datei kann Visforms nicht korrekt arbeiten, weil dieses JavaScript verwendet und darauf angewiesen ist, dass keine JavaScript Fehler vorliegen. (So funktioniert JavaScript leider, Fehler, die A macht, verhindern auch, dass B richtig arbeiten kann.)

Der JavaScript-Fehler ist auch auf allen Seiten der Webseite vorhanden, nur macht er sich offensichtlich auf anderen Seiten nicht so offensichtlich negativ bemerkbar, weil diese nicht auf JavaScript angewiesen sind, oder nicht funktionierendes JavaScript dort nicht so auffällt.

richard67 commented 5 years ago

I can't confirm that problem on my web site, which is based on Joomla! 3.9.6 and uses an extended version of Shariff. The code is the same as current Shariff release 3.2.1, except of an additional button for the Facebook Like button. There is no javascript error when loading a page with it, and the integration is as explained in the readme file. See https://www.richard-fath.de/de/software/shariff-plus.html.

Maybe you used a Joomla plugin for integration? In this case you should report the issue there. So or so you have not answered question 3 by @liayn yet:

How do you integrate shariff in your site, what other Javascript is loaded?

If possible, please also give some information about with which browser on which OS you observe the error, so other people can try to replicate the issue.

Franzhitze commented 5 years ago

Hi See the enclosed file with error. I use the latest Joomla and the MyShariff Plugin. I have already send an email to the developer of the plugin.

I use Firefox but the issue is with all browsers including Chrome.

Franzhitze commented 5 years ago

Error of the Joomla MyShariff Plug-in (taken from Firefox browser console):

SCRIPT5007: SCRIPT5007: Unable to get property 'title' of undefined or null reference {key:"getTitle",value:function(){var e=this.getOption("title");

richard67 commented 5 years ago

I assume the error comes from the MyShariff plugin.

richard67 commented 5 years ago

Sure you use the latest version of the MyShariff plugin?

The update history section of https://www.xadomir.de/webentwicklung/cms/joomla/plugins/18-myshariff-en.html shows as newest entry at the top:

2.7.1: TypeError console fix (09.05.2019)

digitalgopnik commented 3 months ago

@richard67 Thanks for your contribution and support.

@Franzhitze Did this fix solved your issue? Can we close this issue here?

Franzhitze commented 3 months ago

Hallo,

Ich nutze Shariff nicht mehr und kann dazu nichts sagen.

@Franshitze

Von: Christian Ratz @.> Gesendet: 20 March 2024 20:44 An: heiseonline/shariff @.> Cc: Mention @.>; Franzhitze @.> Betreff: Re: [heiseonline/shariff] JavaScript Fehler in shariff.min.js:7(#364)

@richard67 https://github.com/richard67 Thanks for your contribution and support.

@Franzhitze https://github.com/Franzhitze Did this fix solved your issue? Can we close this issue here?

— Reply to this email directly, view it on GitHub https://github.com/heiseonline/shariff/issues/364#issuecomment-2010483980 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AK6F75ICD5STJQNFUIIJB3LYZHRIFAVCNFSM4HQK26NKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBRGA2DQMZZHAYA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AK6F75OTKGP5I35XJF5U5YDYZHRIFA5CNFSM4HQK26NKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOO7KY2DA.gif Message ID: @. @.> >

[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/heiseonline/shariff/issues/364#issuecomment-2010483980", "url": "https://github.com/heiseonline/shariff/issues/364#issuecomment-2010483980", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]