search

heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 176 forks source link

Feature Request: Shariff without jQuery #372

Open markymcfly opened 4 years ago

markymcfly commented 4 years ago

It would be great if this plugin worked without jQuery!

onli commented 9 months ago

I built that at https://github.com/onli/shariff-plus - shariff-plus is a maintained fork of shariff, which I forked again to remove jQuery. Currently, my code also removes the dialog that defined the plus in shariff-plus, making it just a patched, modernized version of shariff (but I might restore that dialog to make it easier for shariff-plus to incorporate my changes).

Is this project interested in getting a similar modernization for shariff itself? Having done the work already once, I could repeat it and send in a PR. Or the project could just copy the code.

My approach also eliminates all the old modules and babel stuff, as it is not needed in modern browsers. The idea would be to use something like rollup.js instead. That would make maintaining this project a lot easier, especially if you also get rid of the LESS files. But that's your decision.

liayn commented 9 months ago

@onli Thanks for speaking up here. I, as maintainer of the TYPO3 integration, would be interested of course, but it's up to Heise (@pmb0) to decide that. I'm actually surprised that we saw a release recently again. If the decision is negative, I will most probably adjust our integration to use a shariff-plus variant.