search

heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 177 forks source link

use svgs for icons #46

Closed Schweinepriester closed 9 years ago

Schweinepriester commented 9 years ago

title says all.

see https://css-tricks.com/icon-fonts-vs-svg/

joomla-agency commented 9 years ago

This can maybe reduce a big amount of not needed font awesome fluff?!

craiq commented 9 years ago

The Browser support is the problem: "It all comes down to browser support. If you can go IE 9+ / Android 3+, inline SVG is better at pretty much everything than icon fonts. If you need the deeper browser support, I feel like an inline SVG fallback would be too big of a pain to be worth it (maintaining a PNG copy, inserting an additional element to display PNG version, hiding SVG element... it's weighty)."

IE8 is still common.

And the way it is, it's easier to implement with just one css and one js file.

The fluff in the CSS file can be cut out. But then you can't use the other icons from the font with just set a class to an element anymore. If you don't need this, you can take a look at my branch. (translations modifiable, more modules, new css) http://craiq.github.io/shariff/

compeak commented 9 years ago

As @craiq said:

The Browser support is the problem

mwld commented 6 years ago

Coming back to this after two years. SVG icons are now widely supported and used. They also provide better quality than an icon font.

You could use Material Icons and bundle them directly with Shariff.

flowtron commented 6 years ago

FYI: FontAwesome now also comes in an SVG-flavour, which is also faster to render ;-)

Schweinepriester commented 2 years ago

I believe this issue is still/again relevant and should be reopened given https://caniuse.com/svg and the slow but sure death of IE11 ;)