heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 176 forks source link

Using Pinterest widget HTML on page breaks Shariff's Pinterest button #86

Closed hzulla closed 9 years ago

hzulla commented 9 years ago

Pinterest recommends using this HTML to embed a widget on its page:

pinterest

<a data-pin-do="embedUser" href="http://de.pinterest.com/kitchennerds/"></a>
<!-- Please call pinit.js only once per page -->
<script type="text/javascript" async defer src="//assets.pinterest.com/js/pinit.js"></script>

However, calling pinit.js will break the Shariff Pinterest button when used on the same page. After its deferred execution, it replaces the Pinterest button in Shariff and the Wordpress Shariff Wrapper plugin will look like this:

shariff

startef commented 9 years ago

Hi hzulla,

I'm one of the developers of the WordPress plugin you seem to be using. First off: Using an original Pinterest script kind of defeats the purpose of the Shariff buttons, because now your widget sends data about your visitors to Pinterest. So in the spirit of the Shariff idea, it is not wise to use other scripts on your page that do not respect the privacy of your visitors.

Nevertheless, I just committed a fix for this problem to our plugin as well as to the original Shariff code. The update should be pushed to wordpress.org very soon.

JP

hzulla commented 9 years ago

Hi,

First off: Using an original Pinterest script kind of defeats the purpose of the Shariff buttons

Yes, I'm aware of that. Still, thank you very much for fixing this.