heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 177 forks source link

Not showing up correctly on my website #9

Closed kwoxer closed 9 years ago

kwoxer commented 9 years ago

Well tried it out on my website. Since it's a "Baukasten-Website" (kwoxer.de), it has no real FTP access.

So I tried to link to the Github RAW content. No share button comes up in the bottom right. Just the text... but looking in the Firefox Inspector he seems to find the JS and CSS.

Since there are no errors in the console, here are the things I did so far:

How can I fix that? Thanks.

compeak commented 9 years ago

Content from raw.github.com is not meant to be directly embedded into websites. Files are served using the MIME-type text/plain and with a X-Content-Type-Options: nosniff header. This means browsers (at least Chrome) will not execute the Javascript.

Use http://rawgit.com/ or put the files on a github.io page.

(Please mind: I don't know if that will fix your problem. It's just something I noticed.)

kwoxer commented 9 years ago

Indeed, that was the reason. Just put the css file there and now it's working properly. Thank you.

Should I also put the JS file there or no need?

compeak commented 9 years ago

I would recommend that. My Chromium 37 does not execute Javascript served with the plain/text MIME-type.

kwoxer commented 9 years ago

Jap all working now (Chrome/Firefox). Not that easy with Jimdo but possible ;)

Thanks.