heiseonline / shariff

👮 Shariff enables website users to share their favorite content without compromising their privacy.
http://ct.de/-2467514
MIT License
1.4k stars 176 forks source link

Issue with language codes #97

Closed McAtze closed 9 years ago

McAtze commented 9 years ago

There're some lang codes which are not clearly what country is it. Are this ISO 3166 lang codes (https://en.wikipedia.org/wiki/ISO_3166-1)?

ja (??), ko (??), sl (sierra leone ??), sr (suriname ??), sv (el salvador ??) and zh (??)

Thanks for helping.

craiq commented 9 years ago

you can check the code, eg https://github.com/heiseonline/shariff/blob/master/src/js/services/facebook.js

and then use https://translate.google.com/ with language recognition

ja = japan, ko = korean, sl = slovenian, ...

heppstux commented 9 years ago

Hello @McAtze,

at least in my understanding, translations should follow iso-639-1's two-letter-codes (compare https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes).

If you find translations in shariff not respecting this standard let us know!

Thanks in advance

compeak commented 9 years ago

This question seems to be answered. Feel free to reopen.