heissgetraenk / fcmcua

FreeCAD Motion Control Workbench: Link a motion controller to a FreeCAD assembly using OPC UA
GNU General Public License v3.0
14 stars 4 forks source link

Add to FreeCAD Addon Manager #17

Closed luzpaz closed 1 year ago

luzpaz commented 1 year ago

https://github.com/FreeCAD/FreeCAD-addons#adding-your-workbench-to-the-collection

luzpaz commented 1 year ago

What are the 3rd party dependencies of this workbench?

heissgetraenk commented 1 year ago

asyncua, which in turn needs aiofiles

luzpaz commented 1 year ago

Thanks, are they available via pip ? If so what are their official names?

heissgetraenk commented 1 year ago

pip install asyncua installs both, i believe. https://github.com/FreeOpcUa/opcua-asyncio

luzpaz commented 1 year ago

@chennes will the addon manager autoinstall both if one is the dependency of the other? :point_up_2:

chennes commented 1 year ago

Yes, the AM just uses pip, so it will follow whatever dependency chain a normal pip install does. You only need to specify your actual dependency, not all the things it depends on.

luzpaz commented 1 year ago

Are we good to add 'asyncua' (https://github.com/FreeOpcUa/opcua-asyncio) to the https://github.com/FreeCAD/FreeCAD-addons/blob/master/ALLOWED_PYTHON_PACKAGES.txt file ?

chennes commented 1 year ago

No problems here.

luzpaz commented 1 year ago

Thanks chennes. Merged in https://github.com/FreeCAD/FreeCAD-addons/pull/248
Now we need a package.xml