search

heistp / irtt

Isochronous Round-Trip Tester
GNU General Public License v2.0
185 stars 23 forks source link

Add packet TOS option to client command #12

Closed mlouielu closed 6 years ago

mlouielu commented 6 years ago

Hi, this is my first time to write go, so if there have any coding style or idiom problem, please let me know, thanks.

Currently, TOS option is set to 0 in conn.go/init, this PR add a new TOS option to irtt client for user to choose which TOS level they want to use.

heistp commented 6 years ago

Hi, in the init function SetTOS and SetTrafficClass are called only to test whether or not support for those exists. I use the name DSCP instead of TOS, so the option to set TOS (DSCP) is already there, and called --dscp. Let me know if it works for you.

mlouielu commented 6 years ago

Ah, yep, --dscp does the thing I want!

Maybe the help text can add some words about QoS, and this table?

heistp commented 6 years ago

Ok, I added this to my todo list and will do it shortly when I get a chance. Thanks for the feedback!