Handling offset frameRects properly

heitorfr / ios-image-editor

iOS View Controller for image cropping. An alternative to the UIImagePickerController editor with extended features.

MIT License

602 stars 129 forks source link

Handling offset frameRects properly #17

Closed iellis closed 11 years ago

iellis commented 11 years ago

This fixes an issue I was having where I have a navigation bar above the frameView, which caused the image to be offset from the crop area incorrectly. This is because cropRect is used in view-space in HFImageEditorFrameView, but in screen-space in HFImageEditorViewController.

Commit message: Making HFImageEditorFrameView store screenspace coordinates for cropRect so that HFImageEditorViewController respects frameView origins other than 0,0

P.S. This library really helped me out. Thanks!

heitorfr commented 11 years ago

Thanks for the fix and for the feedback too :+1: