heitzmann / gdstk

Gdstk (GDSII Tool Kit) is a C++/Python library for creation and manipulation of GDSII and OASIS files.
https://heitzmann.github.io/gdstk/
Boost Software License 1.0
324 stars 78 forks source link

Cell.dependencies cannot use a named-argument #218

Closed nmz787-intel closed 7 months ago

nmz787-intel commented 7 months ago

I want to be clear what this argument for dependencies is, so when I read the code later, or other team members read it, it makes sense. So I wanted to use a named/keyword argument:

for child_cell in topcell.dependencies(recursive=True):
        lib.add(child_cell)

however, I get

TypeError: dependencies() takes no keyword arguments

Hopefully adding this is an easy fix in the C++ extension!

Rishabhgoyal07 commented 7 months ago

You don't have to write recursive=True in the argument, only 'True' you have to write, then it will not show any error.

nmz787-intel commented 7 months ago

You don't have to write recursive=True in the argument, only 'True' you have to write, then it will not show any error.

Yes, I know this. I want to use the keyword arg to have my code be more self-documenting.