heitzmann / gdstk

Gdstk (GDSII Tool Kit) is a C++/Python library for creation and manipulation of GDSII and OASIS files.
https://heitzmann.github.io/gdstk/
Boost Software License 1.0
324 stars 78 forks source link

0.9.51: Doesn't install include directory and .pc file #245

Closed yurivict closed 1 week ago

yurivict commented 2 months ago

These lines disappeared:

install(FILES ${CMAKE_CURRENT_BINARY_DIR}/gdstk.pc DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)
CONFIGURE_FILE("gdstk.pc.in" "gdstk.pc")

This line also disappeared:

include(GNUInstallDirs)

It probably installed the include directory.

heitzmann commented 2 months ago

That's right, the whole build system changed because there were too many hacks. The gdstk.pc was one of them. It was not properly created and was starting to break on Windows.

The headers I forgot to check after the changes, but I've put them back in the latest commit.

yurivict commented 2 months ago

Do you intend to make a corrected release?

heitzmann commented 1 month ago

Sorry, I thought I had already released this... I've prepared the release locally and completely forgot to push!