Change enum name to prevent confusion

hejare / jaws

The Frontend (and more) microservice for Sharkster

0 stars 2 forks source link

Change enum name to prevent confusion #146

Closed annagustavsson closed 1 year ago

annagustavsson commented 1 year ago

This causes no changes in DB. However, maybe it would be reasonable to change the field "type" in DB to "side". To prevent confusion. In DB, our field "type" has values that correspond to the alpaca API's field "side".

@ Alpaca:

valid values for side are "buy" or "sell"
- valid valued for type is: market, limit, stop, stop_limit, trailing_stop

@ our DB:

type is set to "buy" or "sell"

leopoldroos commented 1 year ago

Yes that is very good suggestions. Change "type" -> "side" Add "type" as alpaca-type values Keep "status" since this is up to us to use however we see fit. It often has similar values as the alpaca-type values, but we have states that are not - and should not require to be- represented in their list of values.