IHC binding and autoupdate

[GoogleCodeExporter]

One modification on IHC binding related to autoupdate functionality is not 
committed to main repo. Change was "hided" when I was merged  main repo changes 
to my personal repo.

Change set: 
http://code.google.com/r/paulianttila-ihc-binding/source/detail?r=80c904f1bab9a0
ce0b6634527fe5d997d1d4d6c5

Diff: 
http://code.google.com/r/paulianttila-ihc-binding/source/diff?spec=svnb8765e6df3
06cad059a6df3f2dac0aa96b57f6df&r=80c904f1bab9a0ce0b6634527fe5d997d1d4d6c5&format
=side&path=/bundles/binding/org.openhab.binding.ihc/src/main/java/org/openhab/bi
nding/ihc/internal/IhcGenericBindingProvider.java&old_path=/bundles/binding/org.
openhab.binding.ihc/src/main/java/org/openhab/binding/ihc/internal/IhcGenericBin
dingProvider.java&old=401e050bafa06c750fb43f2e57140395564d8911

IhcGenericBindingProvider.java

Current code on main:

    @Override
    public Boolean autoUpdate(String itemName) {

        // Cancel auto update functionality for items, which are handled on this
        // binding

        if (providesBindingFor(itemName)) {

            // TODO: cancel auto update functionality only if item is not 'out binding only'

            logger.debug("AutoUpdate for item {} canceled", itemName);
            return false;
        }

        return null;
    }

Should be:
    @Override
    public Boolean autoUpdate(String itemName) {

        // Cancel auto update functionality for items, which are handled on this binding

        if (providesBindingFor(itemName)) {

            if (isOutBindingOnly(itemName) == false) {

                // Cancel auto update functionality only if item is not 'out binding only'

                logger.debug("AutoUpdate for item {} canceled", itemName);
                return false;
            }
        }

        return null;
    }

Could you merge change to main?

Original issue reported on code.google.com by pauli.an...@gmail.com on 20 Jun 2013 at 3:02

[GoogleCodeExporter]

have it to my local repo and will push soon (have some other things to merge 
first) - Thanks for keeping track ;-)

Original comment by teichsta on 21 Jun 2013 at 5:34

• Changed state: Started
• Added labels: Version-1.3.0
• Removed labels: Version-later

[GoogleCodeExporter]

Original comment by kai.openhab on 7 Aug 2013 at 7:21

• Changed state: ReadyForReview

[GoogleCodeExporter]

added fix to default repo (see 
http://code.google.com/p/openhab/source/detail?r=18bb925280d30f0edd48b9a9f12f468
a7659e8b2)

Thanks, Pali!

Original comment by teichsta on 21 Aug 2013 at 1:23

• Changed state: Fixed