search

helaili / jekyll-action

A GitHub Action to publish Jekyll based content as a GitHub Pages site
MIT License
250 stars 120 forks source link

When the execution fails, the exit code is 0 #24

Closed mberlanda closed 4 years ago

mberlanda commented 4 years ago

I gave a try to this github action and the first execution was green. I was amazed since I did not configure anything.

Looking at the logs, I could find the following last line:

fatal: could not read Username for 'https://github.com': No such device or address

Would it be possible to have a non 0 exit code when the job execution fails?

helaili commented 4 years ago

Ooops, thanks for catching that. I wrote #27 which should fix this. Do you want to have a look before I merge it?