Closed tinacious closed 4 years ago
I've added a follow up re: alternative config on an open PR: https://github.com/helaili/jekyll-action/pull/39#issuecomment-657146133
Ultimately, as mentioned in a comment for that PR that addresses this concern (https://github.com/helaili/jekyll-action/pull/39#issuecomment-657147242), I think explicitly having a section in the docs on how to work with custom domains would be a good approach to solving the currently cumbersome experience with custom domains for those of us that have configured it via the repository settings.
Fixed by #39
I have a repository for a project (not my username), e.g. project-name, that uses my custom domain, e.g. example.com.
After every successful run, the Custom Domain section is blank. This causes my site to 404 because Github doesn't know how to resolve my domain since the setting for it has been removed from the repository settings.
When I set it back to my custom domain, it works again.
This is my action: