should not only push to gh-pages but also master branch

helaili / jekyll-action

A GitHub Action to publish Jekyll based content as a GitHub Pages site

MIT License

250 stars 120 forks source link

should not only push to gh-pages but also master branch #6

Closed tcitry closed 5 years ago

tcitry commented 5 years ago

refer to Configuring a publishing source for GitHub Pages - Github

https://github.com/helaili/jekyll-action/blob/master/entrypoint.sh#L36

helaili commented 5 years ago

Good point @tcitry, thanks!

helaili commented 5 years ago

fixed by #7

mpchadwick commented 4 years ago

So if you have a pre-existing .github.io site on GitHub pages that is not using GitHub actions and you have been pushing to master I guess the migration path would be something like this?

Break a new branch (e.g. "source") off of master
Configure "source" branch under "on/push/branches" in github-pages.yml
Push changes to "source" branch

Since the docs don't currently seem to cover this scenario just want to make sure I'm understanding.

limjh16 commented 4 years ago

Yep, that seems correct @mpchadwick In any case, in a *.github.io repository, if you commit to the "master" branch, the action should throw an error so your files don't get overwritten.