helblazer811 / ManimML

ManimML is a project focused on providing animations and visualizations of common machine learning concepts with the Manim Community Library.
MIT License
2.35k stars 140 forks source link

Misplacement of connections between neurons in NeuralNetworkScene #33

Closed baichuanzhou closed 1 year ago

baichuanzhou commented 1 year ago

I tried to run the example code below:

class NeuralNetworkScene(Scene):
    def construct(self):
        layers = [FeedForwardLayer(3), FeedForwardLayer(5), FeedForwardLayer(3)]
        nn = NeuralNetwork(layers)
        self.add(nn)
        nn.move_to(ORIGIN)
        # nn.scale(2)
        forward_propagation_animation = nn.make_forward_pass_animation(
            run_time=5, passing_flash=True
        )
        self.play(forward_propagation_animation)

And everything is fine. But when I uncomment nn.scale(2), this happened: image It appears that the connections between neurons are misplaced when scaling.

helblazer811 commented 1 year ago

Sorry I never responded to this. I am pretty busy for the next few weeks, but after that I will look into this issue.

helblazer811 commented 1 year ago

Sorry this took so long for me to get back to this. I think I have fixed this. Let me know if you can update your pip package with pip install --upgrade manim-ml. Let me know if it works.

helblazer811 commented 1 year ago

Closing this unless it still does not work.

baichuanzhou commented 1 year ago

Sorry I didn't see your comments before. It works, thank you.

helblazer811 commented 1 year ago

Amazing! No worries at all. Thanks.

On Mon, Apr 17, 2023 at 1:36 PM baichuanzhou @.***> wrote:

Sorry I didn't see your comments before. It works, thank you.

— Reply to this email directly, view it on GitHub https://github.com/helblazer811/ManimML/issues/33#issuecomment-1511796314, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGLRRSVVFMXJQP5V2RLLLXBV5QVANCNFSM6AAAAAAVGQ6BFY . You are receiving this because you modified the open/close state.Message ID: @.***>