search

helblazer811 / ManimML

ManimML is a project focused on providing animations and visualizations of common machine learning concepts with the Manim Community Library.
MIT License
2.35k stars 140 forks source link

missing "config" #38

Open FreqBayes opened 1 year ago

FreqBayes commented 1 year ago

Hi, when I was trying to run the maxpooling example in 0.0.24 it gave me an AttributeError:

convolutional_2d_to_max_pooling_2d.py:170 in make_forward_pass_animation │ │ ❱ 170 │ │ │ │ axis=manim_ml.three_d_config.rotation_axis, │

I think it would be axis=manim_ml.config.three_d_config.rotation_axis

BTW, just wondering is it possible to specify the run_time of each layer? sometimes the ImageLayer plays very fast but Convolutional2DLayer plays too slow.

DoctorDinosaur commented 11 months ago

Same issue here. Tried from GitHub too with pip install git+https://github.com/helblazer811/ManimML.git

AttributeError: module 'manim_ml' has no attribute 'three_d_config'

DoctorDinosaur commented 11 months ago

Pull request fixes the config error. But the animation is running painfully slowly unless you specify run_time, in which case imagelayer -> convolution is way too fast.

helblazer811 commented 11 months ago

Thanks for the help. Could you share your code? You can do some things to change the animation speed, like setting run time for the play function. I do need to do some refactoring of the animation timings in the future though.

On Tue, Nov 7, 2023 at 5:13 PM DoctorDinosaur @.***> wrote:

Pull request fixes the config error. But the animation is running painfully slowly...

— Reply to this email directly, view it on GitHub https://github.com/helblazer811/ManimML/issues/38#issuecomment-1800273621, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGLRRVLQHOQRC2YVKZNRDYDKW67AVCNFSM6AAAAAAXZTQCQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBQGI3TGNRSGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

DoctorDinosaur commented 11 months ago

Same code as https://github.com/helblazer811/ManimML/blob/main/examples/cnn/cnn_max_pool.py

Just adding a runtime arg to the self.play. Or not adding.

Without the anim is like 57 secs.