migration to phetsims - Githubissues

heldentodd / xray-diffraction

This repository contains the code for one simulation, but eventually three are planned: bragg-law, Single Crystal Diffraction, and Powder Diffraction.

GNU General Public License v3.0

1 stars 1 forks source link

migration to phetsims #33

Open pixelzoom opened 4 years ago

pixelzoom commented 4 years ago

This repository will be migrated to https://github.com/phetsims/xray-diffraction.

TODO list:

[x] create new repo phetsims/xray-diffraction and import from heldentodd/xray-diffraction, including all revision history
[x] add xray-diffraction to perennial/data/active-repos
[x] announce the new repo on PhET's dev-public Slack channel
[x] decide what to do about the German translation, xray-diffraction-strings_de.json

heldentodd commented 4 years ago

Ariel mentioned that having QCC affiliation in the code might be problematic, so I changed it to a website about the project. I can introduce myself there. Will probably switch it to a college webpage when I get around to writing one, but this should take care of the problem.

pixelzoom commented 4 years ago

Re:

[ ] decide what to do about the German translation, xray-diffraction-strings_de.json

We discussed this today in weekly PhET developer meeting. The conclusion was that the German "trusted translator" should have a go at this first, using the standard translation process (Rosetta). If they don't get to it in a reasonable amount of time, then someone will ping them.

heldentodd commented 4 years ago

This is fine with me. The translation I put out there might not be the best.

pixelzoom commented 4 years ago

Migration is done, see https://github.com/phetsims/xray-diffraction. @heldentodd you're included as a collaborator with write access.

A few things that I did , in case you want to make similar updates to your repo:

Updated Gruntfile.js to the new standard (see one of the PhET sims)
Updated the README.md using grunt unpublished-README, to indicate that the sim is not yet published.
Deleted xray-diffraction-strings_de.json
Deleted mipmaps/*, since these files are no longer needed after converting to use scenery-phet/ProtractorNode.js

Feel free to close this issue after reviewing.

pixelzoom commented 4 years ago

I also updated package.json, see https://github.com/phetsims/xray-diffraction/commit/2b01adfc3d6fa36f3a58c572c56cc19e88404079.

pixelzoom commented 4 years ago

@heldentodd you've been added to PhET's "Developer Responsibility List" list at https://github.com/phetsims/phet-info/blob/master/sim-info/responsible_dev.md.