search

helen / wp-style-guide

Still not really a real thing. Also more of a pattern library.
327 stars 34 forks source link

if MP6 is required to be installed either mention that or check for it programatically #3

Closed chuckreynolds closed 10 years ago

chuckreynolds commented 10 years ago
  1. this is awesome - need a styleguide fo sho :)
  2. If MP6 is required for the styles... as it seems so far... should the readme at least mention that? and or at some point this plugin would check to see if mp6 was installed/active?

thx

helen commented 10 years ago

I guess the helper classes page is MP6-specific helper classes at the moment - I didn't make it, just ported it over from what was previously hidden in MP6. I guess it assumes MP6, since it was previously in there. This is why I'm not sure what to do with this yet - sort of waiting on where we go in core.

bueltge commented 10 years ago

@chuckreynolds all current default classes can you find in this helper plugin to identifier the right markup and class: https://github.com/bueltge/WordPress-Admin-Style The goal of my old plugin is the same as @helenhousandi , but I have't currently the mp6 topic inside the source. But I have send the issue #5 as question and maybe the answer is the kickoff to merge this two plugins in one plugin for each developers to create default markup.

helen commented 10 years ago

Well, it's merged into 3.8 now, so we probably need to do some stuff to that page but don't need to worry about this anymore.