helenasokk / autoware_mini_practice_solutions

0 stars 0 forks source link

Practice 2 #2

Closed dmytrozabolotnii closed 2 months ago

dmytrozabolotnii commented 2 months ago

Please remove plain print outputs in the console before submitting (we will cover proper logging later):

https://github.com/helenasokk/autoware_mini_practice_solutions/blob/e3e0093dee1eb98b9e7e83bf67a67d0bf883f6a6/nodes/localization/localizer.py#L53

Technically you can create multiple subscriptions in one node from another, and call different functions in them, but you shouldn't. As a solution, you can have one callback function that calls these 2 functions inside it.

https://github.com/helenasokk/autoware_mini_practice_solutions/blob/e3e0093dee1eb98b9e7e83bf67a67d0bf883f6a6/nodes/localization/localizer.py#L27-L28

Your solution is slightly incorrect, I recommend very carefully looking through your azimuth to yaw calculation. In the correct solution, visualization of the arrow shouldn't be behaving as wildly as it does in yours, which points to the fact that your quaternion result is incorrect.