Closed dmytrozabolotnii closed 1 month ago
Great job on the practice. One small note about code:
It is good practice to append the name of the node throwing warnings/errors in the console in front through rospy.get_name():
https://github.com/helenasokk/autoware_mini_practice_solutions/blob/2324018edae869ef42dfc8948a1f838a1b9d45a6/nodes/detection/points_clusterer.py#L28
https://github.com/helenasokk/autoware_mini_practice_solutions/blob/2324018edae869ef42dfc8948a1f838a1b9d45a6/nodes/detection/points_clusterer.py#L55
Great job on the practice. One small note about code:
It is good practice to append the name of the node throwing warnings/errors in the console in front through rospy.get_name():
https://github.com/helenasokk/autoware_mini_practice_solutions/blob/2324018edae869ef42dfc8948a1f838a1b9d45a6/nodes/detection/points_clusterer.py#L28
https://github.com/helenasokk/autoware_mini_practice_solutions/blob/2324018edae869ef42dfc8948a1f838a1b9d45a6/nodes/detection/points_clusterer.py#L55