Great job on the practice. Here are some code comments:
Please clean code from extensive warning like this one, you can use throttle or throttle identical function, or implement logic that shows warning once unless conditions for it are back (i.e. there should be one warning when path is not set, no warnings until path is set, and then when the vehicle executes the path, there should be a second warning that the path is not set):
Great job on the practice. Here are some code comments:
Please clean code from extensive warning like this one, you can use throttle or throttle identical function, or implement logic that shows warning once unless conditions for it are back (i.e. there should be one warning when path is not set, no warnings until path is set, and then when the vehicle executes the path, there should be a second warning that the path is not set):
https://github.com/helenasokk/autoware_mini_practice_solutions/blob/5d09c254bda4a4ea24ff70507b81bd2062ee592b/nodes/planning/local/simple_local_planner.py#L143
For checking red lights you should still operate with local_path_buffer, and not just local_path:
https://github.com/helenasokk/autoware_mini_practice_solutions/blob/5d09c254bda4a4ea24ff70507b81bd2062ee592b/nodes/planning/local/simple_local_planner.py#L192
Class variables should be initiated inside init function first and you need to check if you received transform in the main callback function:
https://github.com/helenasokk/autoware_mini_practice_solutions/blob/5d09c254bda4a4ea24ff70507b81bd2062ee592b/nodes/detection/camera_traffic_light_detector.py#L120
You shouldn't publish roi images before processing:
https://github.com/helenasokk/autoware_mini_practice_solutions/blob/5d09c254bda4a4ea24ff70507b81bd2062ee592b/nodes/detection/camera_traffic_light_detector.py#L137