search

helfer / apollo-link-debounce

An Apollo Link that debounces requests
MIT License
119 stars 22 forks source link

Merge variables objects when flushing queue #10

Open jasimon opened 5 years ago

jasimon commented 5 years ago

Would you be ok with merging the variables object for all queued requests when flushing the queue? It seems to me that for cases where you're updating an object instead of a single value that would be the desired behaviour. Happy to take a crack at it if you're open.

helfer commented 5 years ago

I think that could be useful, but it should be optional, and ideally configurable per debounce key, so one debounce link could debounce requests both with and without merging variables.

jasimon commented 4 years ago

Looks like I don't have permissions to push to the repo? I took a pass at it, curious to get your thoughts.

helfer commented 4 years ago

Yeah, you'll have to push to your own fork and then open a pull request.

-------- Original Message -------- On Dec 7, 2019, 3:08 PM, jasimon wrote:

Looks like I don't have permissions to push to the repo? I took a pass at it, curious to get your thoughts.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

jasimon commented 4 years ago

Sorry for the delay, PR here: https://github.com/helfer/apollo-link-debounce/pull/11