search

helfrichmichael / prusaslicer-novnc

Simple Docker container that serves Prusaslicer via noVNC in your web browser.
52 stars 20 forks source link

Update tag_latest_prusaslicer.sh to pull the most-recent release, including preview builds #12

Closed longman391 closed 2 months ago

longman391 commented 1 year ago

Now pulls a pre-release version if it's the latest tagged build. This mirrors the behavior set within PrusaSliver itself, where it will alert the user if there is a new build available, not just anything tagged "latest."

longman391 commented 1 year ago

Different approach and more features, but note that this has just been incorporated into the upstream repo: https://github.com/dmagyar/prusaslicer-vnc-docker/issues/1#issuecomment-1520911100

helfrichmichael commented 1 year ago

Hi @longman391 , sorry for the delay. I'm adjusting my notifications for GitHub to make sure I don't miss these.

Happy to do a pull, but I'm wondering if it's worth having 2 branches (stable/prerelease) for the prusaslicer-novnc docker container. Shouldn't be unreasonable.

Otherwise if there's strong confidence in the Prusa beta offerings, I'm happy to merge this PR.

markrossington commented 1 year ago

A prerelease branch (as long as you can grab it via :prerelease or whatever in Docker would be great.

longman391 commented 1 year ago

Hi @longman391 , sorry for the delay. I'm adjusting my notifications for GitHub to make sure I don't miss these.

Happy to do a pull, but I'm wondering if it's worth having 2 branches (stable/prerelease) for the prusaslicer-novnc docker container. Shouldn't be unreasonable.

Otherwise if there's strong confidence in the Prusa beta offerings, I'm happy to merge this PR.

It would be AWESOME to have another branch for prerelease, thanks! Oftentimes Prusa only has support for their newest printers on the prerelease branch, so for those of us with beta hardware and new hardware, there's no way to use this docker without prerelease support.

Thank you!

helfrichmichael commented 1 year ago

Sorry again for the delay here. I gave an update on https://github.com/helfrichmichael/prusaslicer-novnc/issues/10#issuecomment-1615452383. I think since latest is now the latest, we'll avoid merging this in, but ideally I'll keep the builds updating more frequently and include pre-releases.