search

helfrichmichael / prusaslicer-novnc

Simple Docker container that serves Prusaslicer via noVNC in your web browser.
52 stars 20 forks source link

[FR] Modify the noVNC favicon to be the Prusaslicer icon #2

Closed helfrichmichael closed 2 months ago

helfrichmichael commented 2 years ago

Like the title states, there's an opportunity to improve the descriptiveness of the Prusaslicer noVNC webpage. Currently the page title is useful, but the icon is the generic noVNC favicon which isn't necessarily descriptive. There's a few ways to approach this so far in my mind:

1) Fork the upstream Easy noVNC container to modify the favicon while it's building from source (shortly after pulling the ZIP, it can modify the files or favicons.

2) Investigate further if there are any noVNC parameters for specifying a favicon (nothing that I've found so far).

Defining this as a feature request as it's not determinantal to the performance or behavior.

helfrichmichael commented 2 months ago

Pushing to Docker now.

helfrichmichael commented 2 months ago

Reopening as the images seem to be corrupt, but locally they seem right in my repo. Going to look into this tomorrow.

helfrichmichael commented 2 months ago

Forgot to mark this fixed!