search

helgatheviking / Nav-Menu-Roles

Display / Hide wp_nav_menu() items by role
65 stars 32 forks source link

Two TODOs #46

Closed szepeviktor closed 1 year ago

szepeviktor commented 4 years ago 
    <rule ref="WordPress-Core">
        <!-- TODO Use strict comparisions! -->
        <exclude name="WordPress.PHP.StrictComparisons"/>
        <!-- TODO Tell translators what is up! -->
        <exclude name="WordPress.WP.I18n"/>
    </rule>

Start by simply remove exclude-s.

szepeviktor commented 1 year ago

@helgatheviking Hello 👋🏻

PHPCS says there are 42 problems 😭

helgatheviking commented 1 year ago

Hi :wave: Hmm... I just fixed a bunch and now I am only seeing the following

FILE: src/customize-controls.js

FOUND 3 ERRORS AFFECTING 3 LINES

13 | ERROR | [x] Multi-line function call not indented correctly; expected 8 spaces but found 12 | | (PEAR.Functions.FunctionCallSignature.Indent) 16 | ERROR | [x] Multi-line function call not indented correctly; expected 20 spaces but found 24 | | (PEAR.Functions.FunctionCallSignature.Indent) 39 | ERROR | [x] Multi-line function call not indented correctly; expected 12 spaces but found 16 | | (PEAR.Functions.FunctionCallSignature.Indent)

And I can't seem to fix it, because when I do, it gives me a different error about tabs being wrong. So damned if you do, damned if you don't.

szepeviktor commented 1 year ago

PEAR comes from a time when there was no fat arrow function.

helgatheviking commented 1 year ago

That probably explains it. I gave up... a little indentation error isn't going to hurt anybody one way or the other.