search

helgatheviking / Radio-Buttons-for-Taxonomies

Turn any WordPress taxonomy into a list of radio buttons, which forces users to select only 1 term!
53 stars 28 forks source link

[dev] Focused radio button styles underlapping wrapping container #56

Closed leymannx closed 5 years ago

leymannx commented 5 years ago

Following https://github.com/helgatheviking/Radio-Buttons-for-Taxonomies/issues/53#issuecomment-486125368 I found the styles of a focused radio button looks a little bit odd as its overlapped by the wrapping container. Is this WP core interfering?

Adding screenshots for clarification:

Screenshot 2019-04-24 10 32 39 Screenshot 2019-04-24 10 33 02

helgatheviking commented 5 years ago

I don't think I'm adding any styles. But I did see this too. Doesn't seem to be a problem for places where they are using radio in core.. like post status.

On Wed, Apr 24, 2019, 5:40 PM Norman Kämper-Leymann < notifications@github.com> wrote:

Following #53 (comment) https://github.com/helgatheviking/Radio-Buttons-for-Taxonomies/issues/53#issuecomment-486125368 I found the styles of a focused radio button looks a little bit odd as its overlapped by the wrapping container. Is this WP core interfering?

Adding screenshots for clarification:

[image: Screenshot 2019-04-24 10 32 39] https://user-images.githubusercontent.com/3585653/56645126-5be21880-667d-11e9-8ce5-36d078c4d342.png [image: Screenshot 2019-04-24 10 33 02] https://user-images.githubusercontent.com/3585653/56645137-600e3600-667d-11e9-8eb9-b31afb8e9c13.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/helgatheviking/Radio-Buttons-for-Taxonomies/issues/56, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD3ZEMYDUMJ636ZQUZYI23PSAMIHANCNFSM4HIBUTYA .

helgatheviking commented 5 years ago

As far as I can tell, this is also a problem in core. Therefore, I may not make any specific changes. If they add a little margin for checkboxes it should be ok in Radio buttons too.

image

leymannx commented 5 years ago

Ah yes, thanks a lot for confirming Kathy! I guess then we can close this issue as "works as designed" or "not our bug", I'd say.

helgatheviking commented 5 years ago

Agreed! Not my bug! :) Was just about to open an issue at Gutenberg, but it appears there already is one.

Let me try to get this packaged up and into the SVN repo.

helgatheviking commented 5 years ago

PS- thanks for all your help testing!

leymannx commented 5 years ago

You are welcome! Was really a pleasure to help you and watch the progress. Can you please ping me one last time as soon as the update is released on wordpress.org? I think I'm going to tweet about it and need to update my review on wordpress.org.

helgatheviking commented 5 years ago

@leymannx did my usual fight with SVN but 2.0 is now in the repo! will definitely appreciate you updating the review.

leymannx commented 5 years ago

Wow that was fast! I updated my review. ⭐️ ⭐️ ⭐️ ⭐️ ⭐️

leymannx commented 5 years ago

Do you know how to update the "Tested up to:" version as well? I think it should say 5.1.1

Screenshot 2019-04-24 17 48 53

helgatheviking commented 5 years ago

Yes, looks like I updated that in the plugin file, but forgot to update on the readme.txt which is where the .org page pulls it's info from.

Updated!

On Thu, Apr 25, 2019, 12:51 AM Norman Kämper-Leymann < notifications@github.com> wrote:

Do you know how to update the "Tested up to:" version as well? I think it should say 5.1.1

[image: Screenshot 2019-04-24 17 48 53] https://user-images.githubusercontent.com/3585653/56673980-84880380-66b9-11e9-966a-0d842d0f2fea.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/helgatheviking/Radio-Buttons-for-Taxonomies/issues/56#issuecomment-486301119, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD3ZENLTCUWFTXJUGH3AL3PSB6XNANCNFSM4HIBUTYA .