helge17 / tuxguitar

Improve TuxGuitar and provide builds
Other
414 stars 35 forks source link

Songsteer download #102

Closed thedoggaming16 closed 6 days ago

thedoggaming16 commented 1 year ago

Yes hello, i think it's a bug but if i download the Walk files in Songsterr (https://www.songsterr.com/a/wsa/pantera-walk-tab-s22271) and open it on Tuxguitar for i don't know what reason all of the tracks are like trumpets.... I don't know if it's a bug or anything but yea... it's weirdand now walk sound like taco bell anthem xD.

thedoggaming16 commented 1 year ago

and =it also do this for Master of puppet, Fade to black, Symphony of destruction...

guiv42 commented 1 year ago

@thedoggaming16: could you please elaborate a bit on the complete procedure, especially how you downloaded the tab? I never used Songsterr, but when I look at the FAQ I find this:

Can I download a tab for offline use?
Songsterr web app is an online-only service. Try our mobile apps instead.

So I must admit I don't understand this issue!

thedoggaming16 commented 1 year ago

Ok so first click here: https://www.songsterr.com/a/wsa/pantera-walk-tab-s22271 After click on Revised on:16/06/2023 And the last contrubution titeld the old one sounds off have a button to download (it going to download .gp file) Open it and you going to see that all of the track are trumpet (same thing for master of puppets , fade to black, symphonium of destruction but not all the tabs do this)

guiv42 commented 1 year ago

I followed the link in your post: is it normal the track in Songsterr is named "Phil Anselmo - Trumpet"? 102

Edit: track in Master of puppets is named "Baritone Sax" It looks the problem is on songsterr's side, not TuxGuitar

thedoggaming16 commented 1 year ago

oki thx !

vincentT commented 3 weeks ago

I reproduced the issue. I downloaded the trial of GP8 and the file downloaded on songsterr (You need to be logged in to be able to edit the file and then download it) works like a charm. However on tuxguitar 1.5.6 and 1.6.3 some instruments are not correctly recognized. I faced it originally with this song https://www.songsterr.com/a/wsa/bullet-for-my-valentine-suffocating-under-words-of-sorrow-bass-tab-s23763?open=editor The 3 first tracks are correctly recognized as Distorsion guitar with dropped C tuning. The 4th track, the drums, is recognized as Piano and the 5th track, a dropped C tuned electric bass played with mediator, is recognized as drums, which is a mess to recover while trying to reassign the right instruments as it will automatically transpose the track (side question, is there a way to assign tuning of strings without changing the frets played in the corresponding string ? maybe it's a feature idea) I also tested it on the song mentioned in the issue and there is a problem with the drum track (2nd track) that is also seen as a Piano.

guiv42 commented 3 weeks ago

@vincentT thanks for testing with GP. So I think issue can be re-opened.

Could you please provide the guitar pro file directly in this conversation, under .zip format? (I have no songsterr account and don't want to create one). If there's a copyright issue, you can empty the content of all tracks with GP8. I only need the list of tracks and their attributes.

paulikauro commented 3 weeks ago

Attached a file which seems to have the same issue: drums are recognized as piano and bass as drums, rest are fine. Additionally, all markers are missing after importing (there is only one marker in the attached file, but in the original all of them go missing). The file is an emptied version of a tab. It was downloaded from (and hence generated by) Songsterr and has not been modified after downloading (apart from renaming the extension gp -> zip).

I don't have GuitarPro to test importing with that. I did test importing in MuseScore 4 and that worked (instruments and markers). Uploading back to Songsterr also works. I'm using TuxGuitar 1.6.3.

test_with_marker.zip

guiv42 commented 3 weeks ago

Thanks for the file. Opening this file with MuseScore 4.3.2:

With TuxGuitar 1.6.3:

the most critical problem is the confusion between percussion/non-percussion tracks (tracks 5 & 6), which is not easy to correct manually. I'll try to have a look.

guiv42 commented 3 weeks ago

Let me reconsider this issue as "enhancement", and not "bug": the way songsterr fills the different fields of the gp file is clearly questionable. TuxGuitar recognizes instruments thanks to the following xml nodes associated to each track:

Primary and secondary channels are left empty in the songsterr gp file. As far as I can see in the few .gp files I have, such fields are correctly set by GuitarPro, which sets them to 9 for percussion tracks. This is what TuxGuitar expects. This explains why track 5 is incorrectly identified as percussion: in absence of information, channels 1 to 8 are arbitrarily allocated to tracks 1 to 4, so channel 9 is allocated to track 5. In 6th track, besides the undefined channels, midi program is set to zero, which corresponds to "Acoustic Grand Piano". No wonder it is recognized as such by TuxGuitar.

In other words: difficult to guarantee interoperability between songsterr and TuxGuitar relying on a proprietary and not well-defined file format.

guiv42 commented 3 weeks ago

@paulikauro : about the marker issue, could you please tell me what is the text associated to the missing marker? I bet for "Test"

paulikauro commented 3 weeks ago

Thanks for looking into this! Track 7 is indeed confusingly named, sorry about that. So the instrument being strings and track name synthesizer should be correct. And yep, the marker's text is "Test".

guiv42 commented 3 weeks ago

OK, thanks for your feedback. I think I can fix that, but it will not be present in next release 1.6.4 (beta1 is already out it's a bit late). Will probably be in following release. Note: I can explain the mismatch between percussion/non-percussion tracks, still it seems quite independent from the first problem raised in this issue (e.g. trumpet instead of guitar). My analysis is also aligned with problem raised by @vincentT in this post: drums track is identified as piano if it's not 5th track, 5th track is erroneously identified as drums.

guiv42 commented 6 days ago

That should be ok now (since release 2024-09-08) @paulikauro, @vincentT: could you please test, and close issue if it's OK?

vincentT commented 6 days ago

I tested it on master branch and it works fine on my case, thanks However I'm not sure to have the right to close issues

guiv42 commented 6 days ago

Thanks!