some text strings cannot be translated

helge17 / tuxguitar

Improve TuxGuitar and provide builds

Other

432 stars 35 forks source link

some text strings cannot be translated #182

Closed guiv42 closed 8 months ago

guiv42 commented 9 months ago

Difficult to build an exhaustive list of hard-coded strings which cannot be translated. A few items (list to be completed):

menu File/open, dialog shows a filter "All Supported Formats"
open an invalid file, error message is "Unsupported Version"
all instruments names (see TGChannelNames and MidiPercussionKey)

guiv42 commented 8 months ago

"All Supported Formats" should be quite easy to fix. For the other cases listed above it's significantly more complex as those strings are defined in modules common to Android and desktop applications. So we have to put in place a new mechanism to propagate translations to such common modules (I could not find any example in the current code base).

guiv42 commented 8 months ago

A few other items identified which cannot be translated:

when creating a new track it is always named "Track N" whatever the language. Note that translation of string "Track" is available, but modules common to desktop and Android cannot access these translated strings.
default template contains a track named "Track 1", with instrument "Steel String Guitar". And the default percussion channel is named "DrumKit". This means that once the midi instruments and "Track" string will be translated, one default template shall be generated for each language

guiv42 commented 8 months ago

All hard-coded strings listed in this issue can now be translated, including strings common to Android and desktop apps. So I close this issue. Logically there should be other hard-coded strings present in the code, so we can either re-open this issue or create another one.