search

helge17 / tuxguitar

Improve TuxGuitar and provide builds
Other
304 stars 29 forks source link

MacOS SWT version used is 4.13 from 2019 and may be upgraded #292

Closed G-eos closed 2 months ago

G-eos commented 3 months ago

Cocoa version used seems to be 4.13 as defined in install.md: https://archive.eclipse.org/eclipse/downloads/drops4/R-4.13-201909161045/swt-4.13-cocoa-macosx-x86_64.zip This version is from 2019. I have no idea of the difficulty to update, probably today OS version is better supported.

This is probably a o-long term enhancement.

G-eos commented 3 months ago

Moreover, https://github.com/helge17/tuxguitar/blob/master/doc/contribute.md explain to use a newer version than Install.md :)

guiv42 commented 3 months ago

I guess you are talking about SWT ? contribute.md details how to configure dev environment to build the Linux version, where "cocoa" is meaningless. Note that the choice of SWT version to use is changing these days... (contribute.md updated yesterday)

G-eos commented 3 months ago

You have probably right, SWT. I follow install.md which defined to download and install swt-4.13-cocoa ... and contribute.md another version (which I see after opening this issue).

As there is discussion on SWT, I propose to close this issue. Or to keep it to track that at least two .md files point to different version, up to you.

guiv42 commented 3 months ago

It's fully possible that different versions of SWT are referred to at different places. Typically, it is not possible now to use the same version on all platforms (freeBSD uses another one).

"contribute.md" explicitly describes how to setup Eclipse environment to build the Linux version. So I think documentation is consistent.

That being said, your proposal to update to a newer version in macOS context could make sense, I don't know. Take care that using the most recent version may not always be the best solution (e.g. Linux openSUSE currently ships SWT version 4.15, see #288)

helge17 commented 3 months ago

See discussion #250, especially under "Cocoa integration plugin": If we could remove (or fix?) this plugin, I would update SWT on MacOS to 4.21 (as on Linux and FreeBSD).

Help with MacOS would be much appreciated in general ;-)

G-eos commented 2 months ago

I think we can close this one. Work is in progress in 355