search

helge17 / tuxguitar

Improve TuxGuitar and provide builds
Other
304 stars 29 forks source link

Adds maven versions plugin #295

Closed profOnno closed 3 months ago

profOnno commented 3 months ago

Adds the plugin to the root pom.xml Adds missing 'version', and 'groupId' element in other pom.xml files

Maybe add merge it in a dev branch. Probably the build scripts needs to be adjusted.

In the tuxguitar/desktop/build-scripts/tuxguitar-linux-swt-x86_64 folder do `

mvn versions:set -DnewVersion=1.6.2-SNAPSHOT -DoldVersion=* -DgroupId=org.herac.tuxguitar -DartifactId=*

Note the groupId, so it is confined.

mvn clean verify

mvn versions:commit when happy.

mvn versions:revert when not happy.

mvn versions:help for other options.

helge17 commented 3 months ago

Not merged, see discussion in #272 and commit f811c19.

profOnno commented 3 months ago

My 'vision' was to use it as a 'client' for the maven part. I'm not (yet) into the Gradle, Debian control, Info.plist parts, so I can be off. I assume you start the build process somewhere and in inject the version, for Gradle, debian, Info.plist etc. then add the mvn versions to do the versions in maven. So not Maven as master to distribute version to all.

helge17 commented 3 months ago

I assume you start the build process somewhere and in inject the version ...

Exactly. This is done in the build script misc/build_tuxguitar_from_source.sh . See also https://github.com/helge17/tuxguitar/discussions/287#discussioncomment-8868638 .