When zoomed in line mode when selecting notes program keeps move back to tact 1 + when using scroll it doesnt scroll horizontal

helge17 / tuxguitar

Improve TuxGuitar and provide builds

Other

432 stars 35 forks source link

When zoomed in line mode when selecting notes program keeps move back to tact 1 + when using scroll it doesnt scroll horizontal #517

Open 666xan666 opened 1 week ago

666xan666 commented 1 week ago

When zoomed in line mode when selecting notes program keeps move back to tact 1.
When you are using horizontal mode mouse scrolls don't scroll horizontally.

666xan666 commented 1 week ago

v. 1.6.4 LM 22. Deb package.

guiv42 commented 1 week ago

when selecting notes program keeps move back to tact 1

Not understood: what action are you doing, what is the expected behavior? Could you please provide a small video to illustrate your problem?

mouse scrolls don't scroll horizontally

Let me try to reword, please tell me if I understood correctly:

type menu View/Page layout, then use mouse wheel: it scrolls vertically, as expected
type menu View/Linear layout, then use mouse wheel: it still scrolls vertically. In this case, scrolling horizontally would be more appropriate

v. 1.6.4 LM 22.

What do you mean with "LM 22"?

666xan666 commented 1 week ago

ad. 1 - when I am on tact for example 10 and I want to select few notes program automatically moves me back to 1st tact. ad. 2 - exactly how you wrote. ad. 3 - LM = Linux Mint 22, kernetl 6.8.0-1013-nvidia-lowlatency

Thank You @guiv42

guiv42 commented 1 week ago

Thanks for answers 2. and 3.

Sorry, I still don't understand you first problem. Could you please provide a detailed description, step-by-step, of the procedure to reproduce? Precise each menu/button/item you click on, each keystroke, etc. And please use the wording of TuxGuitar English interface (e.g. I don't understand what "tact" means). Better if you can provide a video. See example below, I tried to enter notes, select notes, zoom in and out, I cannot get anything wrong.

https://github.com/user-attachments/assets/358bc7c2-a379-4f45-96b0-275e6da255ff

guiv42 commented 1 week ago

OK, after several unsuccessful attempts I could finally download the file, thanks. Next time please just drag-and-drop .mp4 or .zip file here in github. To reproduce:

from default "Untitled.tg" song, add many empty measures
select View / Linear layout
click in measure 1
in tracks table, click in measure 30. This moves the cursor in measure 30 as expected
start a selection with click&drag, starting from cursor position and dragging to the right

Expected behavior: selection of measure 30 and following ones Observed behavior: focus goes back to an earlier measure (14 in the case of video below) where selection starts.

https://github.com/user-attachments/assets/98cc88c8-06b4-4b6c-b84c-4aa071f002ad

666xan666 commented 1 week ago

https://github.com/user-attachments/assets/5f76d528-2998-4e69-b974-84813c56b945

guiv42 commented 1 week ago

analysis ongoing: bug introduced by 20ae8bee2671e52678c0372bc076487eb4b3f95f

guiv42 commented 1 week ago

Two different problems described here:

bug: scrolling issue (see videos above) This should be fixed by #527
enhancement request: convert mouse wheel movements to horizontal scrolling instead of vertical scrolling when in linear mode I understand the proposal, however I'm not so sure it's the best solution. Scrolling vertically can clearly make sense in linear layout, typically for a song with many tracks.

guiv42 commented 19 hours ago

I confirm I prefer not to change the current behavior of mouse wheel in linear mode, for the following reasons:

vertical scrolling still makes sense when there are many tracks
horizontal scrolling is already possible: some mice include a bi-directional wheel, and it is also possible to swipe horizontally with 2 fingers on a touchpad

So, I suggest closing issue