search

helgee / RemoteFiles.jl

Download files from the Internet and keep them up-to-date.
Other
49 stars 8 forks source link

Fixes build error for Julia 1.0 #6

Closed adamryczkowski closed 6 years ago

adamryczkowski commented 6 years ago

It does build and test:

julia> Pkg.test("RemoteFiles")
   Testing RemoteFiles
    Status `/tmp/tmpykjqTC/Manifest.toml`
  [b99e7846] BinaryProvider v0.4.1
  [34da2185] Compat v1.0.1
  [cd3eb016] HTTP v0.6.14
  [83e8ac13] IniFile v0.5.0
  [739be429] MbedTLS v0.6.0
  [cbe49d4c] RemoteFiles v0.2.0+ #master (https://github.com/adamryczkowski/RemoteFiles.jl)
  [2a0f44e3] Base64  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Base64`]
  [ade2ca70] Dates  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Dates`]
  [8bb1440f] DelimitedFiles  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/DelimitedFiles`]
  [8ba89e20] Distributed  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Distributed`]
  [b77e0a4c] InteractiveUtils  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/InteractiveUtils`]
  [76f85450] LibGit2  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/LibGit2`]
  [8f399da3] Libdl  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Libdl`]
  [37e2e46d] LinearAlgebra  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/LinearAlgebra`]
  [56ddb016] Logging  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Logging`]
  [d6f4376e] Markdown  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Markdown`]
  [a63ad114] Mmap  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Mmap`]
  [44cfe95a] Pkg  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Pkg`]
  [de0858da] Printf  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Printf`]
  [3fa0cd96] REPL  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/REPL`]
  [9a3f8284] Random  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Random`]
  [ea8e919c] SHA  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/SHA`]
  [9e88b42a] Serialization  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Serialization`]
  [1a1011a3] SharedArrays  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/SharedArrays`]
  [6462fe0b] Sockets  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Sockets`]
  [2f01184e] SparseArrays  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/SparseArrays`]
  [10745b16] Statistics  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Statistics`]
  [8dfed614] Test  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Test`]
  [cf7118a7] UUIDs  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/UUIDs`]
  [4ec0a83e] Unicode  [`/home/Adama-docs/Adam/linux/tmp/julia/usr/bin/../share/julia/stdlib/v1.1/Unicode`]
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8090  100  8090    0     0   9375      0 --:--:-- --:--:-- --:--:--  9374
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8090  100  8090    0     0   9958      0 --:--:-- --:--:-- --:--:--  9950
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8090  100  8090    0     0   9270      0 --:--:-- --:--:-- --:--:--  9277
[ Info: Downloading file 'image.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'garbage.garbage' from 'https://garbage/garbage/garbage.garbage'.
[ Info: Downloading file 'garbage.garbage' from 'https://garbage/garbage/garbage.garbage'.
[ Info: Downloading file 'image.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'image.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'image.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'image.png' from 'https://httpbin.org/image/png'.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: garbage
[ Info: Downloading file 'image.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'image.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'image1.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'image2.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'image1.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'image2.png' from 'https://httpbin.org/image/png'.
[ Info: Downloading file 'image1.png' from 'https://httpbin.org/image/png'.
Test Summary: | Pass  Total
RemoteFiles   |   50     50
   Testing RemoteFiles tests passed
coveralls commented 6 years ago

Coverage Status

Coverage decreased (-2.3%) to 95.876% when pulling 536a584b34598c829411823d27168de8f102f491 on adamryczkowski:master into 480b6e8ffb7b12e413a41f699fc4286f9563fe29 on helgee:master.

codecov-io commented 6 years ago

Codecov Report

Merging #6 into master will decrease coverage by 2.33%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   98.21%   95.87%   -2.34%     
==========================================
  Files           3        3              
  Lines         112       97      -15     
==========================================
- Hits          110       93      -17     
- Misses          2        4       +2
Impacted Files Coverage Δ
src/download.jl 90.9% <0%> (-9.1%) :arrow_down:
src/RemoteFiles.jl 96.42% <0%> (-0.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 480b6e8...536a584. Read the comment docs.

helgee commented 6 years ago

Thanks!