search

helgeerbe / certbot-dns-ionos

A certbot plugin for enabling DNS authentication with IONOS
Other
39 stars 11 forks source link

Do not replace any TXT-records #15

Closed jwulf0 closed 2 years ago

jwulf0 commented 2 years ago

Do not replace any TXT-records but rather POST new ones in order to comply with the challenge.

Running the example from your README (with one certificate for both the example-domain and a wildcard certificate below it) kept failing for me. It seems that the challenge expects multiple TXT-records at the same time with the same record name (when running the certbot in manual mode for, there is an explicit hint that this is in compliance with the DNS standard) but the plugin replaces the one it had just created.

This should fix it. Unfortunately, I don't know a lot about python, so I didn't adjust any unit tests. Feel free to merge, modify or ignore this... :)

jwulf0 commented 2 years ago

And only now I realize, in the dev branch something like this has already been merged :D well, this might make this obsolete, idk...

helgeerbe commented 2 years ago

Hi @jwulf0 I'm sorry, that you you had this issue. I totally forgot to merge the changes from dev to main. Thanks for reminding me. I will prepare a new release today. This little plugin runs on my home server and does not need any care.